-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Unable to click topology #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 85.19% 85.33% +0.14%
==========================================
Files 786 786
Lines 16100 16111 +11
Branches 2052 2053 +1
==========================================
+ Hits 13716 13749 +33
+ Misses 2350 2331 -19
+ Partials 34 31 -3
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
...s/observability/src/shared/components/topology/renderers/tooltip/topology-tooltip-popover.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an improvement at least, so if we want to go further with it later, that's fine
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 246 suites 14m 48s ⏱️ Results for commit 25fd22c. |
Description
The popover is positioned near the node or edge where the user hovers or clicks, dynamically adjusting to the screen.
Testing
Visual Testing
Hovering:
After click:
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.