Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Mar 30, 2021

Description

The popover is positioned near the node or edge where the user hovers or clicks, dynamically adjusting to the screen.

Testing

Visual Testing

Hovering:

image

After click:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #731 (1329f52) into main (11efdfb) will increase coverage by 0.14%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   85.19%   85.33%   +0.14%     
==========================================
  Files         786      786              
  Lines       16100    16111      +11     
  Branches     2052     2053       +1     
==========================================
+ Hits        13716    13749      +33     
+ Misses       2350     2331      -19     
+ Partials       34       31       -3     
Impacted Files Coverage Δ
...y/src/shared/components/topology/d3/d3-topology.ts 91.95% <85.71%> (-0.64%) ⬇️
...logy/renderers/tooltip/topology-tooltip-popover.ts 100.00% <100.00%> (ø)
...components/src/popover/popover-position-builder.ts 78.94% <0.00%> (+10.52%) ⬆️
...pover/position-strategy/mouse-position-strategy.ts 67.74% <0.00%> (+58.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11efdfb...1329f52. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement at least, so if we want to go further with it later, that's fine

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu marked this pull request as ready for review April 2, 2021 02:50
@palbizu palbizu requested a review from a team as a code owner April 2, 2021 02:50
@palbizu palbizu requested a review from aaron-steinfeld April 2, 2021 02:50
@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 25fd22c into main Apr 5, 2021
@palbizu palbizu deleted the UnableToClickTopology branch April 5, 2021 13:42
@github-actions
Copy link

github-actions bot commented Apr 5, 2021

Unit Test Results

    4 files  246 suites   14m 48s ⏱️
883 tests 883 ✔️ 0 💤 0 ❌
889 runs  889 ✔️ 0 💤 0 ❌

Results for commit 25fd22c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants