Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Mar 31, 2021

Description

Please include a summary of the change, motivation and context.
feat: adding grouped style

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner March 31, 2021 23:12
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #733 (e1d2181) into main (d52222c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         786      786           
  Lines       16097    16097           
  Branches     2003     2053   +50     
=======================================
  Hits        13715    13715           
  Misses       2349     2349           
  Partials       33       33           
Impacted Files Coverage Δ
...shared/components/card-list/card-list.component.ts 100.00% <100.00%> (ø)
...ts/card-list/container/card-container.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52222c...e1d2181. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…st.component.scss

Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com>
@github-actions

This comment has been minimized.

aaron-steinfeld
aaron-steinfeld previously approved these changes Apr 1, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit d113815 into main Apr 1, 2021
@anandtiwary anandtiwary deleted the add-grouped-style branch April 1, 2021 19:14
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Unit Test Results

    4 files  ±0  246 suites  ±0   15m 1s ⏱️ - 1m 20s
884 tests +1  884 ✔️ +1  0 💤 ±0  0 ❌ ±0 
888 runs  +1  888 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit d113815. ± Comparison against base commit d52222c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants