Skip to content

Conversation

arjunlalb
Copy link
Contributor

@arjunlalb arjunlalb commented Apr 6, 2021

Description

Support displaying beta tag on left nav items.

Testing

Manually verified

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner April 6, 2021 04:46
.expanded {
width: 220px;
overflow-x: hidden;
resize: horizontal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want dynamic resize on the left nav? Since the widths are known ahead of time, we should have already sized appropriately (and I'm curious how the app responds to this changing size)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #747 (ac7c09f) into main (0293dca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   85.33%   85.34%           
=======================================
  Files         786      786           
  Lines       16111    16112    +1     
  Branches     2053     2053           
=======================================
+ Hits        13749    13750    +1     
  Misses       2331     2331           
  Partials       31       31           
Impacted Files Coverage Δ
...ects/components/src/beta-tag/beta-tag.component.ts 100.00% <ø> (ø)
...ents/src/navigation/nav-item/nav-item.component.ts 100.00% <ø> (ø)
...onents/src/navigation/navigation-list.component.ts 85.18% <ø> (ø)
...rojects/components/src/beta-tag/beta-tag.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0293dca...ac7c09f. Read the comment docs.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 051a4ad into main Apr 6, 2021
@arjunlalb arjunlalb deleted the nav-item-beta-tag branch April 6, 2021 12:25
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

Unit Test Results

    4 files  ±0  246 suites  ±0   15m 55s ⏱️ -4s
883 tests ±0  883 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
889 runs  ±0  889 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 051a4ad. ± Comparison against base commit 0293dca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants