Display string enum pipe #752
Conversation
| @Pipe({ | ||
| name: 'htDisplayStringEnum' | ||
| }) | ||
| export class DisplayStringEnumPipe implements PipeTransform { |
There was a problem hiding this comment.
Why not use displayString?
There was a problem hiding this comment.
Hmm. Not sure that will work, or at least it shouldn't. The displayString method shouldn't replace - or _. It should just basically String() any input but not format it... with some extra logic for null checks, arrays, etc.
There was a problem hiding this comment.
I don't think we want to overload display string with this behavior (for example "my-value" would become "My Value", which we don't want the main string pipe doing)
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 786 788 +2
Lines 16115 16129 +14
Branches 2054 2055 +1
=======================================
+ Hits 13753 13765 +12
- Misses 2331 2333 +2
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| // This removes dashes and underscores and gives all words initial caps | ||
| const startCased = startCase(provided); | ||
|
|
||
| // We only want the first word capitalized. |
There was a problem hiding this comment.
If that's what we want, what about capitalize(lowerCase(provided)) - believe that works the same way as startCase:
_.lowerCase('--Foo-Bar--');
// => 'foo bar'
There was a problem hiding this comment.
That does look cleaner, but I think this one fails for camelCase and PascalCase.
There was a problem hiding this comment.
lodash should have ng pipes for each method. 'text' | lowercase | capitalize
Description
We keep using the same code over and over. Turning it into a const method and pipe.