Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 7, 2021

Description

Reducing space in Tab's titles.

Testing

Visual Testing

Before:
image

After:
image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team April 7, 2021 21:24
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #753 (86f6092) into main (24b8a5c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         788      788           
  Lines       16129    16129           
  Branches     2055     2055           
=======================================
  Hits        13765    13765           
  Misses       2333     2333           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b8a5c...86f6092. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 008c492 into main Apr 7, 2021
@palbizu palbizu deleted the ReduceSpaceInTabsTitle branch April 7, 2021 21:45
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

Unit Test Results

    4 files  ±0  247 suites  ±0   15m 6s ⏱️ +9s
884 tests ±0  884 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
890 runs  ±0  890 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 008c492. ± Comparison against base commit 24b8a5c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants