Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

We deprecated the enum version of this and replaced with a string a little while back - making the change here in UI

Testing

Updated UT, manual verification

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner April 9, 2021 22:44
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #758 (48fac24) into main (c5cd97c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   85.34%   85.35%   +0.01%     
==========================================
  Files         788      788              
  Lines       16129    16127       -2     
  Branches     2055     2055              
==========================================
  Hits        13765    13765              
+ Misses       2333     2331       -2     
  Partials       31       31              
Impacted Files Coverage Δ
...argument/graphql-observability-argument-builder.ts 84.31% <ø> (-0.60%) ⬇️
...es/query/entities-graphql-query-builder.service.ts 100.00% <ø> (ø)
...y/entity-topology-graphql-query-handler.service.ts 95.50% <ø> (ø)
...uest/builders/argument/graphql-argument-builder.ts 100.00% <100.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cd97c...48fac24. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit ea618f4 into main Apr 10, 2021
@aaron-steinfeld aaron-steinfeld deleted the change-query-to-scope-string branch April 10, 2021 13:05
@github-actions
Copy link

Unit Test Results

    4 files  ±0  247 suites  ±0   14m 20s ⏱️ -24s
884 tests ±0  884 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
890 runs  ±0  890 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ea618f4. ± Comparison against base commit c5cd97c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants