Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 12, 2021

Description

The color parameter is added to be able to use customs colors in the label of the menu item.

Testing

Visual testing.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner April 12, 2021 19:15
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #767 (cea7de5) into main (7cff1af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         788      788           
  Lines       16127    16128    +1     
  Branches     2055     2055           
=======================================
+ Hits        13765    13766    +1     
  Misses       2331     2331           
  Partials       31       31           
Impacted Files Coverage Δ
...src/menu-dropdown/menu-item/menu-item.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cff1af...cea7de5. Read the comment docs.

@palbizu palbizu requested a review from aaron-steinfeld April 12, 2021 19:30
@palbizu palbizu merged commit 41a3f03 into main Apr 12, 2021
@palbizu palbizu deleted the AddingMenuItemColor branch April 12, 2021 19:35
@github-actions
Copy link

Unit Test Results

    4 files  247 suites   15m 48s ⏱️
884 tests 884 ✔️ 0 💤 0 ❌
890 runs  890 ✔️ 0 💤 0 ❌

Results for commit 41a3f03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants