Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Apr 15, 2021

Description

Please include a summary of the change, motivation and context.
refactor: adding NotIn and IN to operators

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner April 15, 2021 21:18
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #775 (8246dd2) into main (f0295d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         789      789           
  Lines       16145    16145           
  Branches     2060     2060           
=======================================
  Hits        13785    13785           
  Misses       2329     2329           
  Partials       31       31           
Impacted Files Coverage Δ
...a/graphql/filter/graphql-key-value-filter.model.ts 77.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0295d8...8246dd2. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit c9a5b90 into main Apr 15, 2021
@anandtiwary anandtiwary deleted the add-filter-operators branch April 15, 2021 21:34
@github-actions
Copy link

Unit Test Results

    4 files  ±0  248 suites  ±0   15m 34s ⏱️ -18s
889 tests ±0  889 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
895 runs  ±0  895 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c9a5b90. ± Comparison against base commit f0295d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants