-
Notifications
You must be signed in to change notification settings - Fork 11
feat: adding error column in trace table #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 792 792
Lines 16161 16161
Branches 2060 2060
=======================================
Hits 13805 13805
Misses 2325 2325
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are we settling down on Errors
for column name then?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@itssharmasandeep since you added new columns, you would probably have to update the expected model json in this test https://github.com/hypertrace/hypertrace-ui/pull/786/checks?check_run_id=2392888321 FAIL projects/observability/src/pages/explorer/explorer-dashboard-builder.test.ts
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding error column in trace table
Testing
Local testing is done.
Checklist: