fix: close popup on destroy #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 85.43% 85.44% +0.01%
==========================================
Files 792 792
Lines 16198 16199 +1
Branches 2070 2071 +1
==========================================
+ Hits 13838 13841 +3
+ Misses 2329 2327 -2
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
May 4, 2021
anandtiwary
reviewed
May 4, 2021
|
|
||
| // Closing can happen internal to the Popover for things like closeOnBackdropClick. Let the consumer know. | ||
| this.subscription = popover.closed$.subscribe(() => this.popoverClose.emit()); | ||
| this.popover.closed$.subscribe(() => this.popoverClose.emit()); |
There was a problem hiding this comment.
Why are not unsubscribing from this?
There was a problem hiding this comment.
No longer necessary, because the closed observable ends when we invoke close which now will always happen at or before destroy.
anandtiwary
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, when moving away from a view with a popup (for example, a modal) any open popovers remain hanging open. This change ties their lifecycle to the underlying component, so the popover overlay will be removed if the trigger itself is destroyed.
Testing
Tested manually