Skip to content

Conversation

itssharmasandeep
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Local testing done.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner May 7, 2021 07:02
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #828 (ce14bcd) into main (9a0534a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         792      792           
  Lines       16222    16222           
  Branches     1930     1930           
=======================================
  Hits        13861    13861           
  Misses       2329     2329           
  Partials       32       32           
Impacted Files Coverage Δ
...waterfall/api-trace-waterfall-data-source.model.ts 96.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0534a...ce14bcd. Read the comment docs.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 73bb82f into main May 7, 2021
@itssharmasandeep itssharmasandeep deleted the log-attributes branch May 7, 2021 07:08
@github-actions
Copy link

github-actions bot commented May 7, 2021

Unit Test Results

    4 files  ±0  250 suites  ±0   15m 7s ⏱️ +36s
899 tests ±0  899 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
905 runs  ±0  905 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 73bb82f. ± Comparison against base commit 9a0534a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants