Skip to content

fix: bad terrible awful totally unacceptable way of returning from method #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: bad terrible awful totally unacceptable way of returning from method #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...distributed-tracing/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,14 @@ export class TableWidgetRendererComponent

public onSelectChange(changed: TableSelectChange): void {
if (changed.values.length === 0) {
// tslint:disable-next-line: no-void-expression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am i the only one not liking this? :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I actually was on the fence before and totally agree with you now. I'm just teasing because it was still very much in 'nit' territory. 😝

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised Aaron has nothing to say on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do my best to stay out of PRs! but I saw fun comments, so I did look: #823 (comment)

return this.selectFilterSubject.next(this.removeFilters(changed.select.options[0].metaValue.field));
this.selectFilterSubject.next(this.removeFilters(changed.select.options[0].metaValue.field));

return;
}

const tableFilters: TableFilter[] = changed.values.map((option: TableFilterControlOption) => option.metaValue);

// tslint:disable-next-line: no-void-expression
return this.selectFilterSubject.next(this.mergeFilters(toInFilter(tableFilters)));
this.selectFilterSubject.next(this.mergeFilters(toInFilter(tableFilters)));
}

public onCheckboxChange(changed: TableCheckboxChange): void {
Expand Down