Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented May 11, 2021

Description

Please include a summary of the change, motivation and context.
feat: Zero filling missing bucket in Explore Data

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner May 11, 2021 03:53
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #839 (bf17fa1) into main (7c59f3a) will increase coverage by 0.01%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   85.42%   85.44%   +0.01%     
==========================================
  Files         793      793              
  Lines       16231    16252      +21     
  Branches     1930     1932       +2     
==========================================
+ Hits        13865    13886      +21     
  Misses       2334     2334              
  Partials       32       32              
Impacted Files Coverage Δ
...hql/explore/explore-cartesian-data-source.model.ts 89.39% <77.77%> (+0.16%) ⬆️
...d/dashboard/data/graphql/explore/explore-result.ts 100.00% <100.00%> (ø)
...lorer-visualization-cartesian-data-source.model.ts 84.21% <100.00%> (+1.85%) ⬆️
...sian-widget/cartesian-widget-renderer.component.ts 97.72% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c59f3a...bf17fa1. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@arjunlalb arjunlalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandtiwary anandtiwary merged commit 80af206 into main May 11, 2021
@anandtiwary anandtiwary deleted the explore-zero-fill branch May 11, 2021 15:27
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 37s ⏱️ +16s
899 tests ±0  899 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
905 runs  ±0  905 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80af206. ± Comparison against base commit 7c59f3a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants