Skip to content

feat: allow user to configure default string and separator for dislay… #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2021
Merged

feat: allow user to configure default string and separator for dislay… #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
048a451
feat: allow user to configure default string and separator for dislay…
jake-bassett May 12, 2021
4441e0b
feat: fix naming
jake-bassett May 12, 2021
a49ff74
fix: simplify
jake-bassett May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/common/src/utilities/formatters/enum/display-string-enum.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { displayStringEnum } from './display-string-enum';
name: 'htDisplayStringEnum'
})
export class DisplayStringEnumPipe implements PipeTransform {
public transform(value: string): string {
return displayStringEnum(value);
public transform(value?: string, defaultValue: string = '-', separator: string = ' '): string {
return displayStringEnum(value, defaultValue, separator);
}
}
12 changes: 4 additions & 8 deletions projects/common/src/utilities/formatters/enum/display-string-enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
import { isNil, startCase } from 'lodash-es';
import { capitalize, isNil, lowerCase } from 'lodash-es';

export const displayStringEnum = (provided?: string): string => {
export const displayStringEnum = (provided?: string, defaultValue: string = '-', separator: string = ' '): string => {
if (isNil(provided)) {
return '-';
return defaultValue;
}

// This removes dashes and underscores and gives all words initial caps
const startCased = startCase(provided);

// We only want the first word capitalized.
return `${startCased[0]}${startCased.substr(1).toLowerCase()}`;
return capitalize(lowerCase(provided)).replace(' ', separator);
};