-
Notifications
You must be signed in to change notification settings - Fork 11
feat: download trace #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: download trace #867
Conversation
Codecov Report
@@ Coverage Diff @@
## main #867 +/- ##
=======================================
Coverage 85.35% 85.36%
=======================================
Files 798 799 +1
Lines 16393 16428 +35
Branches 2057 2062 +5
=======================================
+ Hits 13992 14023 +31
- Misses 2369 2373 +4
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
...ing/src/shared/graphql/request/handlers/traces/export-spans-graphql-query-handler.service.ts
Outdated
Show resolved
Hide resolved
projects/distributed-tracing/src/pages/trace-detail/trace-detail.page.component.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
<ht-download-json | ||
class="download" | ||
[dataSource]="this.exportSpans$" | ||
[fileName]="traceDetails.id + '.json'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (slightly more readable, IMO):
[fileName]="traceDetails.id + '.json'" | |
fileName="{{traceDetails.id}}.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!!
Description
Download trace.
one {traceId}.json file will be downloaded
Testing
Local testing done.
Checklist: