Skip to content

Conversation

itssharmasandeep
Copy link
Contributor

Description

Download trace.
one {traceId}.json file will be downloaded

Testing

Local testing done.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner May 20, 2021 14:23
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #867 (cf4a8ab) into main (2189e8a) will increase coverage by 0.00%.
The diff coverage is 87.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   85.35%   85.36%           
=======================================
  Files         798      799    +1     
  Lines       16393    16428   +35     
  Branches     2057     2062    +5     
=======================================
+ Hits        13992    14023   +31     
- Misses       2369     2373    +4     
  Partials       32       32           
Impacted Files Coverage Δ
...mponents/src/download-json/download-json.module.ts 100.00% <ø> (ø)
.../pages/trace-detail/trace-detail.page.component.ts 30.00% <0.00%> (-1.58%) ⬇️
...src/pages/trace-detail/trace-detail.page.module.ts 100.00% <ø> (ø)
...ing/src/pages/trace-detail/trace-detail.service.ts 92.15% <25.00%> (-5.72%) ⬇️
...nents/src/download-json/download-json.component.ts 46.66% <50.00%> (-1.73%) ⬇️
projects/distributed-tracing/src/public-api.ts 100.00% <100.00%> (ø)
...oard/data/graphql/graphql-handler-configuration.ts 100.00% <100.00%> (ø)
...aces/export-spans-graphql-query-handler.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2189e8a...cf4a8ab. Read the comment docs.

@github-actions

This comment has been minimized.

anandtiwary
anandtiwary previously approved these changes May 24, 2021
Base automatically changed from download-json to main May 24, 2021 13:21
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

<ht-download-json
class="download"
[dataSource]="this.exportSpans$"
[fileName]="traceDetails.id + '.json'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (slightly more readable, IMO):

Suggested change
[fileName]="traceDetails.id + '.json'"
fileName="{{traceDetails.id}}.json"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit f45651b into main May 24, 2021
@itssharmasandeep itssharmasandeep deleted the download-trace branch May 24, 2021 16:12
@github-actions
Copy link

Unit Test Results

    4 files  ±0  254 suites  +1   14m 31s ⏱️ - 1m 12s
914 tests +4  914 ✔️ +4  0 💤 ±0  0 ❌ ±0 
920 runs  +4  920 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit f45651b. ± Comparison against base commit 2189e8a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants