Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jun 3, 2021

Description

Radio buttons disabled new styles.

Testing

Visual Testing

Old:
image

New:
image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner June 3, 2021 22:41
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #901 (9ee81da) into main (da0ac13) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         803      803           
  Lines       16492    16492           
  Branches     2067     2067           
=======================================
  Hits        14082    14082           
  Misses       2378     2378           
  Partials       32       32           
Impacted Files Coverage Δ
...ects/components/src/radio/radio-group.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0ac13...9ee81da. Read the comment docs.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit b7b3d09 into main Jun 3, 2021
@palbizu palbizu deleted the DisabledRadioButtonsStyle branch June 3, 2021 23:32
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Unit Test Results

    4 files  ±0  257 suites  ±0   14m 0s ⏱️ -5s
925 tests ±0  925 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
931 runs  ±0  931 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b7b3d09. ± Comparison against base commit da0ac13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants