Skip to content

feat: adding options alignment in Radio Group #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2021
Merged

feat: adding options alignment in Radio Group #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95bc48c
feat: adding options alignment in Radio Group
Jun 9, 2021
e085308
feat: changing radio group default
Jun 9, 2021
255869b
feat: merge with main
Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions projects/components/src/radio/radio-group.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
}

.radio-group {
display: flex;

&.row {
flex-direction: row;
}

&.column {
flex-direction: column;
}

::ng-deep .radio-button {
line-height: 18px;
padding-right: 10px;
Expand Down
9 changes: 9 additions & 0 deletions projects/components/src/radio/radio-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { RadioOption } from './radio-option';
<ht-label class="title" [label]="this.title"></ht-label>
<mat-radio-group
class="radio-group"
[ngClass]="this.optionsDirection"
[ngModel]="this.selected!.value"
(change)="this.onRadioChange($event)"
[disabled]="this.disabled"
Expand Down Expand Up @@ -39,6 +40,9 @@ export class RadioGroupComponent implements OnInit {
@Input()
public disabled: boolean | undefined;

@Input()
public optionsDirection: OptionsDirection = OptionsDirection.Column;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an input within the radiogroup component. so it can use a simpler name. perhaps just orientation or direction?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bad update to make (I'd opt for orientation, and update the enum too to something like RadioGroupOrientation), worth doing before this gets consumed anywhere.


@Output()
public readonly selectedChange: EventEmitter<string> = new EventEmitter();

Expand All @@ -63,3 +67,8 @@ export class RadioGroupComponent implements OnInit {
this.selectedChange.emit(event.value);
}
}

export const enum OptionsDirection {
Row = 'row',
Column = 'column'
}