Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

This fixes a bug where when a table filter is applied and a user uses the internal refresh in the top bar, the table controls get cleared and there is no indication to the user that the filter is still applied. With this change, we now look at the currently applied filters and reapply them to the table controls upon refresh.

@jake-bassett jake-bassett requested a review from a team as a code owner June 10, 2021 23:24
@jake-bassett jake-bassett requested a review from skjindal93 June 10, 2021 23:25
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #923 (e6b09e0) into main (d02e165) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   85.17%   85.14%   -0.04%     
==========================================
  Files         806      806              
  Lines       16618    16636      +18     
  Branches     2088     2093       +5     
==========================================
+ Hits        14154    14164      +10     
- Misses       2432     2440       +8     
  Partials       32       32              
Impacted Files Coverage Δ
...omponents/src/table/controls/table-controls-api.ts 16.66% <ø> (ø)
...d/widgets/table/table-widget-renderer.component.ts 46.25% <18.18%> (-2.67%) ⬇️
...nts/src/table/controls/table-controls.component.ts 79.22% <100.00%> (+3.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02e165...e6b09e0. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@itssharmasandeep itssharmasandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 97213da into main Jun 11, 2021
@jake-bassett jake-bassett deleted the fix-retain-table-control-filters-on-refresh branch June 11, 2021 18:38
@github-actions
Copy link

Unit Test Results

    4 files  ±0  258 suites  ±0   15m 52s ⏱️ + 2m 16s
929 tests ±0  929 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
935 runs  ±0  935 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 97213da. ± Comparison against base commit d02e165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants