Skip to content

Conversation

itssharmasandeep
Copy link
Contributor

Description

  • Small interaction buttons
  • Adding new box style config

Testing

Local testing done

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner June 25, 2021 11:42
@itssharmasandeep
Copy link
Contributor Author

@jake-bassett Please have a look into this, for me small buttons works fine.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #945 (200e440) into main (f560538) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         812      812           
  Lines       16722    16723    +1     
  Branches     2004     2004           
=======================================
+ Hits        14226    14227    +1     
  Misses       2464     2464           
  Partials       32       32           
Impacted Files Coverage Δ
...ets/topology/topology-widget-renderer.component.ts 97.91% <ø> (ø)
...ractions/topology-interaction-control.component.ts 51.11% <100.00%> (ø)
...ashboard/widgets/topology/topology-widget.model.ts 83.33% <100.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f560538...200e440. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@arjunlalb arjunlalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@itssharmasandeep itssharmasandeep merged commit c039beb into main Jun 25, 2021
@itssharmasandeep itssharmasandeep deleted the topology-style-change branch June 25, 2021 16:39
@github-actions
Copy link

Unit Test Results

    4 files  259 suites   14m 26s ⏱️
936 tests 936 ✔️ 0 💤 0 ❌
942 runs  942 ✔️ 0 💤 0 ❌

Results for commit c039beb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants