Skip to content

Conversation

anandtiwary
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #952 (8b93d45) into main (b909313) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   85.05%   85.02%   -0.04%     
==========================================
  Files         812      812              
  Lines       16723    16729       +6     
  Branches     2004     2004              
==========================================
  Hits        14223    14223              
- Misses       2468     2474       +6     
  Partials       32       32              
Impacted Files Coverage Δ
.../edge/curved/entity-edge-curve-renderer.service.ts 97.05% <0.00%> (-2.95%) ⬇️
...api-node-renderer/api-node-box-renderer.service.ts 100.00% <ø> (ø)
...node-renderer/backend-node-box-renderer.service.ts 85.71% <ø> (ø)
...ology/node/box/entity-node-box-renderer.service.ts 77.33% <0.00%> (-1.58%) ⬇️
...node-renderer/service-node-box-renderer.service.ts 100.00% <ø> (ø)
...ets/topology/topology-widget-renderer.component.ts 97.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b909313...8b93d45. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 40s ⏱️ - 1m 4s
937 tests ±0  937 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
943 runs  ±0  943 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8b93d45. ± Comparison against base commit b909313.

@anandtiwary anandtiwary closed this Jul 1, 2021
@anandtiwary anandtiwary deleted the topo-properties-poc branch July 1, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant