Skip to content

feat: link support for topology widget #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2021
Merged

feat: link support for topology widget #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
646d092
feat: adding link support for topology widget
itssharmasandeep Jul 1, 2021
575ce17
fix: console error for a test
itssharmasandeep Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/dashboards/src/public-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ export * from './widgets/widget-renderer';
export * from './widgets/interactive-data-widget-renderer';
export * from './widgets/header/widget-header.model';
export * from './widgets/container/container-widget.model';
export * from './widgets/link/link-widget.model';

export * from './dashboard.module';
5 changes: 2 additions & 3 deletions ...s/distributed-tracing/src/shared/components/log-events/log-events-table.component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,13 @@ describe('LogEventsTableComponent', () => {

test('should render data correctly for sheet view', fakeAsync(() => {
spectator = createHost(
`<ht-log-events-table [logEvents]="logEvents" [logEventsTableViewType]="logEventsTableViewType" [startTime]="startTime"></ht-log-events-table>`,
`<ht-log-events-table [logEvents]="logEvents" [logEventsTableViewType]="logEventsTableViewType"></ht-log-events-table>`,
{
hostProps: {
logEvents: [
{ attributes: { attr1: 1, attr2: 2 }, summary: 'test', timestamp: '2021-04-30T12:23:57.889149Z' }
],
logEventsTableViewType: LogEventsTableViewType.Condensed,
startTime: 1619785437887
logEventsTableViewType: LogEventsTableViewType.Condensed
}
}
);
Expand Down
6 changes: 5 additions & 1 deletion ...observability/src/shared/dashboard/widgets/topology/topology-widget-renderer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ import { TopologyWidgetModel } from './topology-widget.model';
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="topology-container" [ngClass]="{ 'box-style': this.model.enableBoxStyle }">
<ht-titled-content [title]="this.model.title | htDisplayTitle">
<ht-titled-content
[title]="this.model.title | htDisplayTitle"
[link]="this.model.link?.url"
[linkLabel]="this.model.link?.displayText"
>
<div class="visualization" *htLoadAsync="this.data$ as data">
<div *ngIf="this.model.showLegend" class="legend">
<div class="latency">
Expand Down
22 changes: 21 additions & 1 deletion projects/observability/src/shared/dashboard/widgets/topology/topology-widget.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
import { BOOLEAN_PROPERTY, Model, ModelApi, ModelProperty, STRING_PROPERTY } from '@hypertrace/hyperdash';
import { LinkWidgetModel } from '@hypertrace/dashboards';
import {
BOOLEAN_PROPERTY,
Model,
ModelApi,
ModelModelPropertyTypeInstance,
ModelProperty,
ModelPropertyType,
STRING_PROPERTY
} from '@hypertrace/hyperdash';
import { ModelInject, MODEL_API } from '@hypertrace/hyperdash-angular';
import { Observable } from 'rxjs';
import { TopologyData, TopologyDataSourceModel } from '../../data/graphql/topology/topology-data-source.model';
Expand All @@ -16,6 +25,17 @@ export class TopologyWidgetModel {
})
public title?: string;

@ModelProperty({
key: 'link',
required: false,
// tslint:disable-next-line: no-object-literal-type-assertion
type: {
key: ModelPropertyType.TYPE,
defaultModelClass: LinkWidgetModel
} as ModelModelPropertyTypeInstance
})
public link?: LinkWidgetModel;

@ModelProperty({
key: 'showLegend',
displayName: 'Show Legend',
Expand Down