fix: menu dropdown should not be shown if no items in the list #967

arjunlalb · 2021-07-03T09:17:20Z

Description

Menu dropdown should not be shown if there are no menu items to show.

Testing

UT added.

Checklist:

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules

codecov · 2021-07-03T09:20:41Z

Codecov Report

Merging #967 (8647f50) into main (820b1cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         812      812           
  Lines       16742    16742           
  Branches     2165     2165           
=======================================
  Hits        14238    14238           
  Misses       2473     2473           
  Partials       31       31

Impacted Files	Coverage Δ
...nents/src/menu-dropdown/menu-dropdown.component.ts	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820b1cb...8647f50. Read the comment docs.

…e-ui into no-menu-if-no-items

itssharmasandeep

LGTM

github-actions · 2021-07-06T14:47:21Z

Unit Test Results

    4 files 259 suites 14m 9s ⏱️
938 tests 938 ✔️ 0 💤 0 ❌
944 runs 944 ✔️ 0 💤 0 ❌

Results for commit 05b0dce.

fix: menu dropdown should not be shown if no items in the list

0e404c0

arjunlalb requested a review from a team as a code owner July 3, 2021 09:17

Merge branch 'main' into no-menu-if-no-items

0670e27