Skip to content

Conversation

itssharmasandeep
Copy link
Contributor

@itssharmasandeep itssharmasandeep commented Jul 13, 2021

Description

  1. Responsive title and value text font size
  2. Responsive legend width according to the container
  3. Smaller legend text looks better

Testing

Local testing done!!

Checklist:

  • My changes generate no new warnings

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner July 13, 2021 12:46
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #988 (8612b01) into main (68fbce5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   85.06%   85.10%   +0.04%     
==========================================
  Files         820      822       +2     
  Lines       16863    16917      +54     
  Branches     2190     2043     -147     
==========================================
+ Hits        14344    14397      +53     
- Misses       2488     2489       +1     
  Partials       31       31              
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)
...ents/src/navigation/nav-item/nav-item.component.ts 100.00% <ø> (ø)
...ts/components/src/not-found/not-found.component.ts 100.00% <ø> (ø)
...ponents/src/summary-list/summary-list.component.ts 84.61% <ø> (ø)
...shared/components/bar-gauge/bar-gauge.component.ts 100.00% <ø> (ø)
...rc/navigation/navigation-list-component.service.ts 100.00% <100.00%> (ø)
...onents/src/navigation/navigation-list.component.ts 86.20% <100.00%> (+2.20%) ⬆️
...omponents/src/navigation/navigation-list.module.ts 100.00% <100.00%> (ø)
projects/components/src/public-api.ts 100.00% <100.00%> (ø)
...c/shared/components/donut/donut-builder.service.ts 85.48% <100.00%> (+0.48%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fbce5...8612b01. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

jake-bassett
jake-bassett previously approved these changes Jul 16, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 7c2ba4b into main Jul 29, 2021
@itssharmasandeep itssharmasandeep deleted the donut-fixes branch July 29, 2021 17:21
@github-actions
Copy link

Unit Test Results

    4 files  ±0  263 suites  ±0   15m 39s ⏱️ - 1m 26s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7c2ba4b. ± Comparison against base commit e2d498f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants