-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve aligment issues (#649) #650
fix: resolve aligment issues (#649) #650
Conversation
Signed-off-by: KUNAL <goudanikunal3@gmail.com>
@stealth-bombeer Thank you for the contribution! Could you please add some screenshots to show the UI changes? It would be very helpful for others to check out. Thanks! |
@wxharry , i've added pictures when screen is resized as well in fullscreen mode same changes are being applied to Most Participated Repo |
Thanks, nice work! Could you also align the graph title and the period? I believe they are supposed to be in the same row. 😆 |
They are aligned in a block manner because when the screen becomes smaller the period tends to float on the graph container which lead to issue(#647 ) collapsing of graph and description ,even the Perceptor Tab of Repo is designed the same way 🙂 |
The fix to the repo graphs is fine, the title and period is not separate. But this fix splits title and period into two lines which is not expected. Also, the developer graphs also have the issue similar to #647. I wonder if you would like to fix that? |
Alright got it,i'll try to make it responsive i.e i'll wrap the period to the next line only when it is colliding with the title Untitled.1.mp4does this make sense ? |
Signed-off-by: KUNAL <goudanikunal3@gmail.com>
I've committed all the changes as asked by you ,now you can take a look when you're free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM, thank you so much @stealth-bombeer !
/approve Hi @stealth-bombeer, we are currently developing v1.9.0, where we introduced a brand new feature loading mechanism. In this repo, most time we follow the GitHub flow, i.e. we only maintain a single That is a trouble, we have to often pick changes in |
Sure,i'll make all the necessary changes and create a PR for v1.9.0 branch 👍 |
git worktree is recommended for working on multiple branches(with different dependencies) in the same time :) |
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
Currently the Developer Network/Most Participated Repo of user profile is not aligned leading to misalignments of the description and the graph I've added appropriate styles to the following components such that they align according to their parent component
Checklist
Others
N.A