Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve aligment issues (#649) #650

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix: resolve aligment issues (#649) #650

merged 2 commits into from
Apr 19, 2023

Conversation

stealth-bombeer
Copy link
Contributor

@stealth-bombeer stealth-bombeer commented Apr 16, 2023

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Currently the Developer Network/Most Participated Repo of user profile is not aligned leading to misalignments of the description and the graph I've added appropriate styles to the following components such that they align according to their parent component

Split

fullscreen

Checklist

Others

N.A

Signed-off-by: KUNAL <goudanikunal3@gmail.com>
@menbotics menbotics bot added the kind/bug Category issues or prs related to bug. label Apr 16, 2023
@wxharry
Copy link
Collaborator

wxharry commented Apr 17, 2023

@stealth-bombeer Thank you for the contribution! Could you please add some screenshots to show the UI changes? It would be very helpful for others to check out. Thanks!

@stealth-bombeer
Copy link
Contributor Author

@wxharry , i've added pictures when screen is resized as well in fullscreen mode same changes are being applied to Most Participated Repo

@wxharry
Copy link
Collaborator

wxharry commented Apr 17, 2023

@wxharry , i've added pictures when screen is resized as well in fullscreen mode same changes are being applied to Most Participated Repo

Thanks, nice work! Could you also align the graph title and the period? I believe they are supposed to be in the same row. 😆

@stealth-bombeer
Copy link
Contributor Author

stealth-bombeer commented Apr 17, 2023

@wxharry , i've added pictures when screen is resized as well in fullscreen mode same changes are being applied to Most Participated Repo

Thanks, nice work! Could you also align the graph title and the period? I believe they are supposed to be in the same row. 😆

They are aligned in a block manner because when the screen becomes smaller the period tends to float on the graph container which lead to issue(#647 ) collapsing of graph and description ,even the Perceptor Tab of Repo is designed the same way 🙂

@wxharry
Copy link
Collaborator

wxharry commented Apr 17, 2023

They are aligned in a block manner because when the screen becomes smaller the period tends to float on the graph container which lead to issue(#647 ) collapsing of graph and description ,even the Perceptor Tab of Repo is designed the same way 🙂

The fix to the repo graphs is fine, the title and period is not separate. But this fix splits title and period into two lines which is not expected.

Also, the developer graphs also have the issue similar to #647. I wonder if you would like to fix that?

@stealth-bombeer
Copy link
Contributor Author

stealth-bombeer commented Apr 17, 2023

They are aligned in a block manner because when the screen becomes smaller the period tends to float on the graph container which lead to issue(#647 ) collapsing of graph and description ,even the Perceptor Tab of Repo is designed the same way 🙂

The fix to the repo graphs is fine, the title and period is not separate. But this fix splits title and period into two lines which is not expected.

Also, the developer graphs also have the issue similar to #647. I wonder if you would like to fix that?

Alright got it,i'll try to make it responsive i.e i'll wrap the period to the next line only when it is colliding with the title

Untitled.1.mp4

does this make sense ?

Signed-off-by: KUNAL <goudanikunal3@gmail.com>
@stealth-bombeer
Copy link
Contributor Author

They are aligned in a block manner because when the screen becomes smaller the period tends to float on the graph container which lead to issue(#647 ) collapsing of graph and description ,even the Perceptor Tab of Repo is designed the same way 🙂

The fix to the repo graphs is fine, the title and period is not separate. But this fix splits title and period into two lines which is not expected.

Also, the developer graphs also have the issue similar to #647. I wonder if you would like to fix that?

I've committed all the changes as asked by you ,now you can take a look when you're free

Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, thank you so much @stealth-bombeer !

image

@tyn1998
Copy link
Member

tyn1998 commented Apr 19, 2023

/approve

Hi @stealth-bombeer, we are currently developing v1.9.0, where we introduced a brand new feature loading mechanism. In this repo, most time we follow the GitHub flow, i.e. we only maintain a single master branch. However, considering that v1.9.0 is a huge task we cannot finish it in short time, we created another branch(v1.9.0) to work on with.

That is a trouble, we have to often pick changes in master and apply them to v1.9.0 again. The solution is to finish v1.9.0 ASAP 😆. So would you mind applying all changes you made to master so far to v1.9.0 and create a PR to that branch?

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Apr 19, 2023
@menbotics menbotics bot merged commit 2220a5b into hypertrons:master Apr 19, 2023
@stealth-bombeer
Copy link
Contributor Author

/approve

Hi @stealth-bombeer, we are currently developing v1.9.0, where we introduced a brand new feature loading mechanism. In this repo, most time we follow the GitHub flow, i.e. we only maintain a single master branch. However, considering that v1.9.0 is a huge task we cannot finish it in short time, we created another branch(v1.9.0) to work on with.

That is a trouble, we have to often pick changes in master and apply them to v1.9.0 again. The solution is to finish v1.9.0 ASAP 😆. So would you mind applying all changes you made to master so far to v1.9.0 and create a PR to that branch?

Sure,i'll make all the necessary changes and create a PR for v1.9.0 branch 👍

@tyn1998
Copy link
Member

tyn1998 commented Apr 20, 2023

git worktree is recommended for working on multiple branches(with different dependencies) in the same time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[improvement] CSS styles update needed to ensure aligned
4 participants