Feature/hw 51305 create pay pal account #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsaini-hw
requested review from
skoong,
oleksii-lubianyi-epam,
syyang-hw,
gmeyer-hw,
ekan-hw,
bhordiienko-epam and
ymoskovko-epam
syyang-hw
reviewed
May 8, 2019
| private func deactivatePayPalAccount(_ token: String) { | ||
| Hyperwallet.shared.deactivatePayPalAccount(transferMethodToken: token, | ||
| notes: "Deactivating the PayPal Account", | ||
| completion: deactivateTransferMethodHandler()) |
| @@ -95,7 +95,7 @@ final class AddTransferMethodPresenter { | |||
| else { | |||
| return | |||
| } | |||
| var hyperwalletTransferMethod: HyperwalletTransferMethod | |||
There was a problem hiding this comment.
I think we still can leave it because for most of the cases we don't need to initialize a hyperwalletTransferMethod.
| @@ -115,11 +115,7 @@ final class AddTransferMethodPresenter { | |||
| .build() | |||
|
|
|||
| default: | |||
| hyperwalletTransferMethod = HyperwalletTransferMethod() | |||
| @@ -178,7 +196,13 @@ class ListTransferMethodPresenterTests: XCTestCase { | |||
| transferMethodProfileType: "INDIVIDUAL") | |||
| .build() | |||
| bankCard.setField(key: "token", value: "trm-123456789") | |||
| let transferMethods = [bankAccount, bankCard] | |||
|
|
|||
| let payPalAccount = HyperwalletPayPalAccount.Builder(transferMethodCountry: "US", | |||
There was a problem hiding this comment.
We should use HyperwalletPayPalAccount.Builder(token: "trm-123456789").build()
There was a problem hiding this comment.
We can't. We need country and currency as well
gmeyer-hw
previously approved these changes
May 8, 2019
gmeyer-hw
previously approved these changes
May 8, 2019
…unt' of https://github.com/hyperwallet/hyperwallet-ios-ui-sdk into feature/HW-51305-Create-PayPal-Account # Conflicts: # HyperwalletUISDK.xcodeproj/project.pbxproj # Sources/TransferMethod/AddTransferMethodViewController.swift # UITests/TransferMethod/ListTransferMethodTests.swift
gmeyer-hw
previously approved these changes
May 9, 2019
Conflicts: HyperwalletUISDK.xcodeproj/project.pbxproj
syyang-hw
approved these changes
May 10, 2019
gmeyer-hw
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.