Currency formatting issue fixed and Add Transfer Icon Fix(Ticket 331 and 507) #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparthibanpaypal
requested review from
malaw-hw,
ddhar-hw,
rbanikPP,
SaiNarendran and
shanavas123
shanavas123
approved these changes
Mar 19, 2021
rbanikPP
approved these changes
Mar 19, 2021
rbanikPP
reviewed
Mar 22, 2021
| @@ -89,7 +89,7 @@ extension TransferDestinationCell { | |||
| if !UIFont.isLargeSizeCategory { | |||
| let icon = UIImage.fontIcon(hyperwalletIcon.rawValue, | |||
| Theme.Icon.frame, | |||
| CGFloat(Theme.Icon.size), | |||
| CGFloat(20), | |||
There was a problem hiding this comment.
dont use hardcoded value. Create something like Theme.addIcon.size
There was a problem hiding this comment.
Added constant
| if selectTransferMethodCoordinator == nil { | ||
| tableViewCell.accessoryType = .none | ||
| } | ||
| tableViewCell.accessoryType = .none |
There was a problem hiding this comment.
To hide the arrow mark next to Add Transfer Method title.
SaiNarendran
added
Ready To Merge
aparthibanpaypal
changed the title
jsaini-hw
approved these changes
Mar 24, 2021
ddhar-hw
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.