Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Manifest V2 support #1210

Closed
4 tasks
robertknight opened this issue Apr 19, 2023 · 0 comments · Fixed by #1418
Closed
4 tasks

Remove Manifest V2 support #1210

robertknight opened this issue Apr 19, 2023 · 0 comments · Fixed by #1418

Comments

@robertknight
Copy link
Member

As part of the migration to Manifest V3 we added a build config option (manifestV3) to support building as either MV2 or MV3. We have now changed our production extension over to MV3. Once we are sure that we don't need MV2 any more, we should remove the code.

  • Make the manifestV3 build option the default behavior
  • Remove the manifestV3 build option
  • Remove code paths in eg. chrome-api.ts that support Manifest V2
  • Find remaining references to Manifest V2 in the code and delete them
@robertknight robertknight mentioned this issue Apr 19, 2023
Closed
robertknight added a commit that referenced this issue Nov 30, 2023
@robertknight
Make Manifest V3 the default and only build option
07113ee 
Remove support for building the extension using Manifest V2. We've been shipping
our extension as Manifest V3 since April 2023 and have not encountered any
issues. Removing Manifest V2 support will simplify future development.

Fixes #1210
@robertknight robertknight mentioned this issue Nov 30, 2023
Merged
robertknight added a commit that referenced this issue Nov 30, 2023
@robertknight
Make Manifest V3 the default and only build option
5c41ca3 
Remove support for building the extension using Manifest V2. We've been shipping
our extension as Manifest V3 since April 2023 and have not encountered any
issues. Removing Manifest V2 support will simplify future development.

Fixes #1210
robertknight added a commit that referenced this issue Dec 1, 2023
@robertknight
Make Manifest V3 the default and only build option
e94a034 
Remove support for building the extension using Manifest V2. We've been shipping
our extension as Manifest V3 since April 2023 and have not encountered any
issues. Removing Manifest V2 support will simplify future development.

Fixes #1210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Manifest V3 the default and only build option hypothesis/browser-extension
1 participant
@robertknight