Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump preact from 10.5.13 to 10.5.14 #3557

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2021

Bumps preact from 10.5.13 to 10.5.14.

Release notes

Sourced from preact's releases.

10.5.14

Features

Bug Fixes

Size

Typings

Maintenance

Commits
  • ba8353c Merge pull request #3212 from preactjs/10.5.14
  • 145f167 10.5.14
  • 55ee4bc (fix) - prevent eager child removal (#3210)
  • c52de5c Merge pull request #3204 from preactjs/docs/readme-cli
  • 2937892 docs: Removing suggestion to install Preact CLI
  • 840095d refactor(diff-index): reuse i to reduce size (#3193)
  • 1f89e50 Merge pull request #3191 from craftedsystems/fix/type-definition
  • 9fc9de2 Add valid value options
  • 51d607c Add attribute definition autoCapitalize to HTMLAttributes
  • 50b90f8 Add attribute definition spellCheck to HTMLAttributes
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Jul 5, 2021
@robertknight
Copy link
Member

robertknight commented Jul 6, 2021

The type of useRef changed so that if initialized with a value of type T|null then the returned ref's .current property now has type T|null instead of T.

Preact <= 10.5.13:

foo = useRef(/** @type {HTMLInputElement|null} */ (null));
foo.current // HTMLInputElement

Preact 10.5.14:

foo = useRef(/** @type {HTMLInputElement|null} */ (null));
foo.current // HTMLInputElement|null

The new behavior is technically more correct, but we've written code in various components which assumes the old behavior. In particular the new behavior is quite annoying for the common use case of a DOM ref which starts out as null and transitions to non-null after the first render. I think we should first check upstream that this was definitely an intentional decision, as it deviates from useRef's type definition in React.

@robertknight
Copy link
Member

Related upstream PR - preactjs/preact#3222. TBC whether that resolves this issue.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch 2 times, most recently from 0b3b391 to 59228ef Compare July 15, 2021 21:29
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch from 59228ef to 5b3fb7b Compare August 5, 2021 06:41
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch from 5b3fb7b to 0b6ea7c Compare August 31, 2021 13:04
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch from 0b6ea7c to a676c89 Compare September 13, 2021 11:57
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch 3 times, most recently from 740427c to 7a34ef2 Compare September 27, 2021 10:40
Bumps [preact](https://github.com/preactjs/preact) from 10.5.13 to 10.5.14.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](preactjs/preact@10.5.13...10.5.14)

---
updated-dependencies:
- dependency-name: preact
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.5.14 branch from 7a34ef2 to d5e21d7 Compare October 11, 2021 11:24
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 18, 2021

Superseded by #3845.

@dependabot dependabot bot closed this Oct 18, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/preact-10.5.14 branch October 18, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant