Remove deprecated uses of window.postMessage
#3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
+ Coverage 98.67% 98.89% +0.21%
==========================================
Files 210 210
Lines 7716 7671 -45
Branches 1744 1731 -13
==========================================
- Hits 7614 7586 -28
+ Misses 102 85 -17
Continue to review full report at Codecov.
|
robertknight
approved these changes
Aug 6, 2021
| @@ -59,42 +59,15 @@ const PROTOCOL = 'frame-rpc'; | |||
| */ | |||
| export class RPC { | |||
| /** | |||
| * Create an RPC client for sending RPC requests from `sourceFrame` to | |||
| * `destFrame`, and receiving RPC responses from `destFrame` to `sourceFrame`. | |||
| * Create an RPC client for sending and receiving RPC message using a | |||
There was a problem hiding this comment.
The class documentation could use an update as well. eg.
RPC provides remote procedure calls between frames.
It uses the Channel Messaging API [1] for inter-frame communication.
[1] https://developer.mozilla.org/en-US/docs/Web/API/Channel_Messaging_API
After #3611 there is no more need to support `window.postMessage` on `RPC` and `Bridge` classes.
esanzgar
force-pushed
the
remove-deprecated-functionality
branch
from
c63ee46 to
2e65209
Compare
|
I updated the class documentation. |
The `methods` argument constructor could be an object that uses `this`. However, we do not rely in this feature, so I am suggesting to simplify the execution of the callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3611 there is no need to support
window.postMessageonRPCandBridgeclasses.