Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DefaultIfAny helper #4349

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Remove DefaultIfAny helper #4349

merged 1 commit into from
Mar 24, 2022

Conversation

robertknight
Copy link
Member

Remove a cryptic piece of code that is no longer needed given the ability to
specify default values for template arguments [1]

[1] microsoft/TypeScript#45483

Remove a cryptic piece of code that is no longer needed given the ability to
specify default values for template arguments [1]

[1] microsoft/TypeScript#45483
Copy link
Contributor

@lyzadanger lyzadanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do.

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #4349 (0a6294a) into master (a95447b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4349   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         225      225           
  Lines        8576     8576           
  Branches     2031     2031           
=======================================
  Hits         8503     8503           
  Misses         73       73           
Impacted Files Coverage Δ
src/sidebar/store/create-store.js 93.10% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@@ -196,7 +186,7 @@ export function createStore(modules, initArgs = [], middleware = []) {
* @template State
* @template Actions
* @template {SelectorMap<State>} Selectors
* @template RootSelectors
* @template [RootSelectors={}]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rootSelectors property of store modules is optional. In store modules without it, this treats it as if it were an empty object.

@robertknight robertknight merged commit 788697e into master Mar 24, 2022
@robertknight robertknight deleted the remove-default-if-any branch March 24, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants