Make sure sidebar panels are focused when open, and focus is restored when closed #5390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the new
Dialog
focusing capabilities, to make sure the sidebar panels are focused when opened, and the focus is restored once closed.It's done in a way that the
Slider
transitions are kept, so it has no visual changes.focus-and-transition.mp4
This PR also fixes hypothesis/product-backlog#1421
TODO
Testing steps
First make sure your localNot needed anymore.frontend-shared
is up to date. Then build it withmake build
, and "publish" it withnpx yalc publish
.client
, and runnpx yalc add @hypothesis/frontend-shared
to install the version you published in previous step.