Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ToastMessages from frontend-shared #5884

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Oct 6, 2023

Depends on #5876

Replace local copy of ToastMessages with the one from frontend-shared

Testing steps

Go to http://localhost:3000 and check toast messages look the same.

@acelaya acelaya requested a review from robertknight October 6, 2023 08:15
tailwind-annotator.config.mjs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5884 (07216bf) into main (64ff836) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 07216bf differs from pull request most recent head f2e9809. Consider uploading reports for the commit f2e9809 to get more accurate results

@@            Coverage Diff             @@
##             main    #5884      +/-   ##
==========================================
- Coverage   99.44%   99.44%   -0.01%     
==========================================
  Files         258      257       -1     
  Lines        9926     9874      -52     
  Branches     2372     2359      -13     
==========================================
- Hits         9871     9819      -52     
  Misses         55       55              
Files Coverage Δ
src/annotator/components/ToastMessages.tsx 100.00% <ø> (ø)
src/annotator/sidebar.tsx 98.59% <ø> (ø)
...debar/components/ShareDialog/ExportAnnotations.tsx 100.00% <100.00%> (ø)
...debar/components/ShareDialog/ImportAnnotations.tsx 100.00% <100.00%> (ø)
...components/ShareDialog/UserAnnotationsListItem.tsx 100.00% <100.00%> (ø)
src/sidebar/components/ToastMessages.tsx 100.00% <ø> (ø)
src/sidebar/services/frame-sync.ts 99.06% <ø> (ø)
src/sidebar/services/toast-messenger.ts 100.00% <ø> (ø)
src/sidebar/store/modules/toast-messages.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tailwind-annotator.config.mjs Outdated Show resolved Hide resolved
@acelaya acelaya force-pushed the export-import-select-next branch from b14ba46 to ff47a78 Compare October 6, 2023 09:03
Base automatically changed from export-import-select-next to main October 6, 2023 09:07
@acelaya acelaya force-pushed the shared-toast-messages branch from 07216bf to f2e9809 Compare October 6, 2023 09:12
@acelaya acelaya merged commit 5b096a7 into main Oct 6, 2023
2 checks passed
@acelaya acelaya deleted the shared-toast-messages branch October 6, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants