Replace local pagination component with one from shared library #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6706 +/- ##
==========================================
- Coverage 99.43% 99.43% -0.01%
==========================================
Files 271 269 -2
Lines 10215 10176 -39
Branches 2434 2424 -10
==========================================
- Hits 10157 10118 -39
Misses 58 58 ☔ View full report in Codecov by Sentry. |
robertknight
force-pushed
the
import-pagination
branch
from
11d9525 to
387d1d1
Compare
robertknight
changed the title
acelaya
approved these changes
Dec 10, 2024
This adds the `Pagination` component.
Replace `PaginationNavigation` with `Pagination` component from @hypothesis/frontend-shared. This has an identical look and props, since this component was copied from `PaginationNavigation` originally.
robertknight
force-pushed
the
import-pagination
branch
from
387d1d1 to
396f9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
PaginationNavigationwithPaginationcomponent from@hypothesis/frontend-shared. This has an identical look and props, since this
component was copied from
PaginationNavigationoriginally.