Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find solution to icon registration, prefixing #151

Closed
lyzadanger opened this issue Jul 20, 2021 · 0 comments · Fixed by #221
Closed

Find solution to icon registration, prefixing #151

lyzadanger opened this issue Jul 20, 2021 · 0 comments · Fixed by #221
Assignees
@lyzadanger
Labels
package or API related to the build, structure or API of the frontend-shared package

Comments

@lyzadanger
Copy link
Contributor

lyzadanger commented Jul 20, 2021 •
edited
Loading

To avoid confusion, all icons in this package should be registered with a common prefix, or in some way that does not have conflicts with registration in other projects. This can can help prevent situations like #150 from arising.
@lyzadanger lyzadanger added the pattern library concerning the build, structure, styling or components for the pattern library label Jul 20, 2021
lyzadanger added a commit that referenced this issue Jul 20, 2021
@lyzadanger
Prefix all icons with hyp-
b06177b 
All icon names used in this package should be prefixed with `hyp-` to
avoid ambiguity and collision. The icons registered in the project's
main `icons` module are intended for use in pattern library examples.

All components depending on icons must register them (using the `hyp-`
prefixing).

Fixes #151
@lyzadanger lyzadanger mentioned this issue Jul 20, 2021
Closed
@lyzadanger lyzadanger changed the title All icons in this project should have hyp- prefix Find solution to icon registration, prefixing Aug 3, 2021
@lyzadanger lyzadanger added package or API related to the build, structure or API of the frontend-shared package and removed pattern library concerning the build, structure, styling or components for the pattern library labels Sep 10, 2021
@lyzadanger lyzadanger self-assigned this Oct 1, 2021
@lyzadanger lyzadanger mentioned this issue Oct 4, 2021
Closed
@lyzadanger lyzadanger mentioned this issue Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyzadanger lyzadanger

Labels
package or API related to the build, structure or API of the frontend-shared package
Projects
None yet
Milestone
No milestone
1 participant
@lyzadanger