Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment navigation within pattern-library page not working #557

Closed
lyzadanger opened this issue Aug 9, 2022 · 1 comment · Fixed by #969
Closed

Fragment navigation within pattern-library page not working #557

lyzadanger opened this issue Aug 9, 2022 · 1 comment · Fixed by #969
Labels

Comments

@lyzadanger
Copy link
Contributor

At present, clicking on a link in a pattern-library page to a fragment within the same page does not work. The URL bar is updated, but the viewport does not scroll to the fragment location. Entering the same URL (with hash) directly works.

There's something about the navigate callback in the router that isn't working for this; I haven't investigated it. If I do something hamfisted to make the clickListener return without trying to handle navigating the link (i.e. return before calling navigate), it works.

@lyzadanger lyzadanger added the bug label Aug 9, 2022
@lyzadanger
Copy link
Contributor Author

lyzadanger commented Apr 12, 2023

Note: The lms project is now using wouter-preact for routing.

There are a few notes about authoring a custom hook for supporting hash navigation in the package README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant