Add secondary variant to CardTitle and CardHeader
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzadanger
commented
Apr 26, 2023
| @@ -4,7 +4,15 @@ import type { JSX } from 'preact'; | |||
| import type { PresentationalProps } from '../../types'; | |||
| import { downcastRef } from '../../util/typing'; | |||
|
|
|||
| type ComponentProps = { | |||
| /** Wrap the title with this HTML heading tag */ | |||
| tagName?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5'; | |||
There was a problem hiding this comment.
I realized that we lost something in the most recent round of Card and Panel implementations: we aren't using heading elements. For HTML semantics and accessibility it is best if we do. This prop allows a consumer to use a different heading level than default (h1) if so desired.
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
===========================================
- Coverage 100.00% 99.85% -0.15%
===========================================
Files 53 53
Lines 700 707 +7
Branches 238 244 +6
===========================================
+ Hits 700 706 +6
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'll fix the test miss tomorrow. |
acelaya
approved these changes
Apr 27, 2023
| className={classnames( | ||
| { | ||
| 'text-lg text-brand font-semibold': variant === 'primary', | ||
| 'text-xl text-slate-7 font-normal': variant === 'secondary', |
There was a problem hiding this comment.
Is the text supposed to be bigger on secondary variant? Is that intended?
There was a problem hiding this comment.
Yes, it actually is!
This expresses a design pattern we are using in the `lms` application.
lyzadanger
force-pushed
the
card-variant
branch
from
5f470fb to
dfa231f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expresses a design pattern we are using in the
lmsapplication by updatingvariantsforCardTitleandCardHeaderto add a newsecondaryvariant (default isprimary, the way it "looked before.").This captures the pattern we've started using in panels in the
lmsapp. It will make markup more straightforward for LMS components, and make prototyping within panels of that style faster and more consistent.Partial screen grab of updated
Cardpattern library page, in theCardHeadersection: