Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern library: Adjust margins, add Info, InfoItem components #1029

Merged
merged 4 commits into from
May 18, 2023

Conversation

lyzadanger
Copy link
Contributor

This PR chunks off changes made to the pattern library components to support #1028 so they can be available for other work. You can see them in play, if you so desire, in #1028.

Adjust markup such that the bottom margin of section headings and the
top margin of the first child (if any) collapse. This ensures there is
a predictable vertical margin at the top of sections and doesn't
"double" any margins.
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1029 (142c8c5) into main (baa4a18) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1029   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines          708       708           
  Branches       245       245           
=========================================
  Hits           708       708           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@lyzadanger lyzadanger merged commit 5aad034 into main May 18, 2023
@lyzadanger lyzadanger deleted the pattern-library-improvements branch May 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants