Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objectFit prop to Thumbnail and update documentation #1032

Merged
merged 2 commits into from
May 19, 2023

Conversation

lyzadanger
Copy link
Contributor

This PR adds an objectFit prop to the Thumbnail component that is passed through to AspectRatio. Fixes #842

Updates Thumbnail pattern-library documentation.

Part of #1030

After:

image

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1032 (97078c4) into main (5aad034) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines          708       709    +1     
  Branches       245       246    +1     
=========================================
+ Hits           708       709    +1     
Impacted Files Coverage Δ
src/components/data/Thumbnail.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyzadanger lyzadanger merged commit 9d95fc0 into main May 19, 2023
@lyzadanger lyzadanger deleted the update-thumbnail branch May 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add objectFit prop to Thumbnail component
2 participants