Update LinkButton to use styling API; align with Link
#1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused existing variants
lyzadanger
commented
May 26, 2023
| inline?: boolean; | ||
| underline?: 'always' | 'hover' | 'none'; | ||
| variant?: 'secondary' | 'primary'; |
There was a problem hiding this comment.
Nothing was using either of these!
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 735 741 +6
Branches 265 270 +5
=========================================
+ Hits 735 741 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's Friday's little cleanup effort!
LinkButtonwas out of sync withLinkin terms of API and variants. This PR:LinkButtonto support the styling APIcolorin preference tovariant(and removes the pre-existing, completely-unused variant options! None of our apps were usingprimaryorsecondaryvariants)Fixes #1054
Part of #1030