Add tab variant to Tab and support styling API
#1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzadanger
commented
Jul 19, 2023
Comment on lines
+58
to
+65
| 'font-semibold text-grey-7 rounded-t border border-transparent border-b-0': | ||
| variant === 'tab', | ||
| 'aria-selected:text-color-text aria-selected:bg-white': | ||
| variant === 'tab', | ||
| 'aria-selected:border aria-selected:border-grey-3 aria-selected:border-b-0': | ||
| variant === 'tab', | ||
| 'enabled:hover:text-color-text disabled:text-grey-7/50': | ||
| variant === 'tab', |
There was a problem hiding this comment.
Some of this styling will almost certainly be adapted as we go in this project.
Codecov Report
@@ Coverage Diff @@
## main #1155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 784 791 +7
Branches 298 304 +6
=========================================
+ Hits 784 791 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some support we pretty much know we'll need for the import/export project by adding a new variant to
Tab(calledtab) and extendingTabto support the styling API.See the local Tabs pattern library page for details.
Part of #1141