Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback prop to Select to get it up to speed with Input #1205

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Aug 24, 2023

This PR completes the work done in #1196, adding feedback prop to the Select.

image

@acelaya acelaya requested a review from robertknight August 24, 2023 14:50
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1205 (6d1dfa1) into main (11c9b44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          57       57           
  Lines         808      808           
  Branches      313      313           
=======================================
  Hits          807      807           
  Misses          1        1           
Files Changed Coverage Δ
src/components/input/Select.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acelaya acelaya merged commit 8c144ce into main Aug 25, 2023
@acelaya acelaya deleted the select-feedback branch August 25, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants