Allow type=number and password on Input component #1248
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 836 836
Branches 327 327
=========================================
Hits 836 836
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/components/input/Input.tsx
Outdated
| @@ -5,7 +5,7 @@ import { downcastRef } from '../../util/typing'; | |||
| import InputRoot from './InputRoot'; | |||
|
|
|||
| type ComponentProps = { | |||
| type?: 'email' | 'search' | 'text' | 'url'; | |||
| type?: 'email' | 'search' | 'text' | 'url' | 'number'; | |||
There was a problem hiding this comment.
I suggest to sort these values to make the list easier to scan.
There was a problem hiding this comment.
Also, are there other values for type that we should be enabling? See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types for a list.
There was a problem hiding this comment.
I suggest to sort these values to make the list easier to scan.
Sort how?
There was a problem hiding this comment.
Also, are there other values for type that we should be enabling? See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types for a list.
Perhaps it's worth having password as well.
There was a problem hiding this comment.
I suggest to sort these values to make the list easier to scan.
Sort how?
I have rearranged them a bit, putting text first, as it's the most common and default value.
acelaya
force-pushed
the
number-input
branch
from
4740c10 to
c60ed01
Compare
acelaya
changed the title
No description provided.