Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export useOrderedRows hook #1523

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Export useOrderedRows hook #1523

merged 1 commit into from
Apr 18, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Apr 17, 2024

Export the useOrderedRows hook that was created for the pattern library, but can now be useful in other places, like LMS.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (21ceb38) to head (a3303a1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        61    +1     
  Lines          958       968   +10     
  Branches       364       369    +5     
=========================================
+ Hits           958       968   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review April 18, 2024 07:50
@acelaya acelaya requested a review from robertknight April 18, 2024 07:51
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments on naming and docs.

@acelaya acelaya merged commit 73bf4d9 into main Apr 18, 2024
4 checks passed
@acelaya acelaya deleted the use-ordered-rows branch April 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants