Allow to provide initial order per DataTable column #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 1036 1041 +5
Branches 394 397 +3
=========================================
+ Hits 1036 1041 +5 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
data-table-initial-dir
branch
2 times, most recently
from
bd5a6b7 to
4eb0958
Compare
acelaya
commented
May 27, 2024
| @@ -74,7 +74,7 @@ describe('DataTable', () => { | |||
| ); | |||
| } | |||
|
|
|||
| const createComponent = (Component, props = {}) => { | |||
| const createComponent = ({ Component = DataTable, ...props } = {}) => { | |||
There was a problem hiding this comment.
Not directly related with the main changes in this PR, but to avoid duplicating createComponent(DataTable) over and over, I added a new Component pseudo-prop/option here, which defaults to DataTable.
With this, we can just call createComponent() or createComponent(props) in most of the cases, and when a different component is needed, we can additionally pass createComponent({ Component: Whatever, ...otherProps }).
acelaya
commented
May 27, 2024
robertknight
approved these changes
May 27, 2024
acelaya
force-pushed
the
data-table-initial-dir
branch
from
4eb0958 to
abd4469
Compare
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
initialColumnsOrderDirprop toDataTablewhich is a partial record mapping column names with an order direction.When a column becomes ordered, instead of always defaulting to
ascendingorder, we now first check if that column is defined there. If not defined, we fall back to initially order inascendingdirection.default-order-dir-2024-05-27_14.22.45.mp4