Allow to pass onListboxScroll callback to SelectNext #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
approved these changes
Jul 4, 2024
| </Library.InfoItem> | ||
| <Library.InfoItem label="type"> | ||
| <code> | ||
| () {'=>'} void {'|'} undefined |
There was a problem hiding this comment.
This callback actually receives an Event, although I'm not sure whether you want to promise that in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
onListboxScrollprop toSelectNext, which is basically a callback that gets propagated to the listboxonScroll.As part of the LMS dashboard, we'll use this to dynamically update the options in the list when loading long lists in chunks.
I considered making this smarter, but then I thought there's too many possible requirements that could come from this, and finally decided to make it a dumb callback and let consumers implement the whole logic for now.