Add a very simple introductory page to the pattern library #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzadanger
commented
Aug 5, 2021
Comment on lines
+239
to
+242
| &__subheading { | ||
| font-size: 1.5em; | ||
| font-style: italic; | ||
| } |
There was a problem hiding this comment.
I hope we can start in on a typography design system ASAP.
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 149 149
Branches 51 51
=========================================
Hits 149 149 Continue to review full report at Codecov.
|
esanzgar
approved these changes
Aug 6, 2021
| <h2 className="LibraryPage__subheading">Components</h2> | ||
|
|
||
| <p> | ||
| <strong>Components</strong> are preact components that are built using |
There was a problem hiding this comment.
Suggested change
| <strong>Components</strong> are preact components that are built using | |
| <strong>Components</strong> are Preact components that are built using |
There was a problem hiding this comment.
Interesting, thank you! I had been under the mistaken impression all along that Preact was not capitalized.
lyzadanger
force-pushed
the
quick-library-intro-page
branch
from
43541b5 to
1d0ce9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per popular request, a very simple introductory page for the pattern library (updates to the landing page).
This, of course, wants expansion. But it's a start.
The typography and rhythm look terrible, but we really need to get on a typography system...