Extract some reusable sample components and refactor Dialog examples #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep this markup from cluttering pattern page modules and make it reusable.
lyzadanger
force-pushed
the
pattern-fixtures
branch
from
4f3edab to
99f304c
Compare
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 149 149
Branches 51 51
=========================================
Hits 149 149 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts some components (JSX as HTML markup, basically) into a separate
samplesmodule to keep from over-cluttering pattern-library page modules, and to make things a little more reusable. It also refactors all of the examples on the Dialog Components pattern-library page, which is a standing issue: #148I removed one example on the Dialog page that didn't add a whole lot of value in a Pattern-library context.
I did this now because this stuff was starting to tangle me up as I work on Table-related work (including the need to have an example or two of Tables constrained by Dialogs).
I did this quickly so as not drag out the current line of work (toward Table component) more than is necessary. We could make the new
samplesmodule of components more elegant, or rename it, or whatever, as we go. And the updated Dialog examples could be DRYed out. Being pragmatic here.You can see updated pages by running your local webserver and viewing them in the pattern library.
Fixes #148