Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TS and JSX shared configs from eslint-config-hypothesis #1740

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Oct 18, 2024

Replace some local eslint config with the one introduced in hypothesis/frontend-toolkit#54

@acelaya acelaya force-pushed the shared-eslint-config branch from 8d009bb to fb263f1 Compare October 18, 2024 12:48
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3b0789e) to head (a31e106).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1740   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         1195      1195           
  Branches       449       449           
=========================================
  Hits          1195      1195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings about version mismatches when running Yarn install:

➤ YN0060: │ @hypothesis/frontend-shared@workspace:. provides typescript-eslint (pf2cfc) with version 8.9.0, which doesn't satisfy what eslint-config-hypothesis requests
➤ YN0060: │ @rollup/plugin-commonjs@npm:28.0.0 [035a7] provides picomatch (p6d6d1) with version 2.3.1, which doesn't satisfy what fdir requests
➤ YN0002: │ @typescript-eslint/type-utils@npm:8.9.0 [e5447] doesn't provide eslint (p2296f), requested by @typescript-eslint/utils
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p2e760), requested by @typescript-eslint/utils
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p7c5b4), requested by @typescript-eslint/eslint-plugin
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p21be0), requested by @typescript-eslint/parser
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

Updating typescript-eslint in this repository fixes the first issue. The remaining warnings appear to be due to typescript-eslint/typescript-eslint#9224.

@acelaya acelaya force-pushed the shared-eslint-config branch from fb263f1 to a31e106 Compare October 18, 2024 13:07
@acelaya
Copy link
Contributor Author

acelaya commented Oct 18, 2024

There are some warnings about version mismatches when running Yarn install:

➤ YN0060: │ @hypothesis/frontend-shared@workspace:. provides typescript-eslint (pf2cfc) with version 8.9.0, which doesn't satisfy what eslint-config-hypothesis requests
➤ YN0060: │ @rollup/plugin-commonjs@npm:28.0.0 [035a7] provides picomatch (p6d6d1) with version 2.3.1, which doesn't satisfy what fdir requests
➤ YN0002: │ @typescript-eslint/type-utils@npm:8.9.0 [e5447] doesn't provide eslint (p2296f), requested by @typescript-eslint/utils
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p2e760), requested by @typescript-eslint/utils
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p7c5b4), requested by @typescript-eslint/eslint-plugin
➤ YN0002: │ typescript-eslint@npm:8.9.0 [035a7] doesn't provide eslint (p21be0), requested by @typescript-eslint/parser
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

Updating typescript-eslint in this repository fixes the first issue. The remaining warnings appear to be due to typescript-eslint/typescript-eslint#9224.

I have updated typescript-eslint

@acelaya acelaya merged commit c8ee777 into main Oct 18, 2024
4 checks passed
@acelaya acelaya deleted the shared-eslint-config branch October 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants