Allow title to be provided to Select.Option #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 67 67
Lines 1205 1205
Branches 454 454
=========================================
Hits 1205 1205 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
select-option-title
branch
from
e44a32f to
b48339a
Compare
robertknight
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I have slight reservations about this as tooltips triggered by title are not available on mobile, but it seems like a useful affordance to provide on desktop.
I noted in Slack that Safari automatically shows the full text of an elided element in a tooltip, but Firefox and Chrome do not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass a
titleto theSelect.Option, so that consumers can set a title that's displayed when hovering over any part of the option.If the title is set to the first option's child element instead, then it won't be displayed when hovering over the option's padding, which is unintuitive.