Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new globe-with-lock icon #1775

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add new globe-with-lock icon #1775

merged 2 commits into from
Nov 12, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Nov 11, 2024

Depends on #1774
Part of hypothesis/product-backlog#1597

Add a new globe-with-lock to use with restricted groups.

image

@acelaya acelaya requested a review from robertknight November 11, 2024 11:15
@robertknight
Copy link
Member

There is an existing GlobeAltIcon which looks very similar. What is the status of that?

@acelaya
Copy link
Contributor Author

acelaya commented Nov 11, 2024

There is an existing GlobeAltIcon which looks very similar. What is the status of that?

Oh right! I simply overlooked that. We can keep it, and I'll just name the lock-one GlobeAltLockIcon.

@acelaya acelaya force-pushed the group-type-icons branch 2 times, most recently from dafe19a to 5db9519 Compare November 11, 2024 12:50
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89498a0) to head (0d148a9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1775   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         1204      1204           
  Branches       455       455           
=========================================
  Hits          1204      1204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya changed the title Add new world icons Add new world-with-lock icon Nov 11, 2024
@acelaya acelaya changed the title Add new world-with-lock icon Add new globe-with-lock icon Nov 11, 2024
Base automatically changed from update-lock-icon to main November 12, 2024 10:31
@acelaya acelaya merged commit a3f4eb6 into main Nov 12, 2024
4 checks passed
@acelaya acelaya deleted the group-type-icons branch November 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants